[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PULL 01/23] kvm/ioapic: dump real object instead of a fake

From: Paolo Bonzini
Subject: [Qemu-devel] [PULL 01/23] kvm/ioapic: dump real object instead of a fake one
Date: Thu, 16 Feb 2017 15:31:25 +0100

From: Peter Xu <address@hidden>

When we do "info ioapic" for kvm ioapic, we were building up a temporary
ioapic object. Let's fetch the real one and update correspond to the
real object as well.

This fixes printing uninitialized version field in

Reported-by: Peter Maydell <address@hidden>
Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
 hw/i386/kvm/ioapic.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/i386/kvm/ioapic.c b/hw/i386/kvm/ioapic.c
index 8eb2c7a..716d59a 100644
--- a/hw/i386/kvm/ioapic.c
+++ b/hw/i386/kvm/ioapic.c
@@ -114,11 +114,11 @@ static void kvm_ioapic_put(IOAPICCommonState *s)
 void kvm_ioapic_dump_state(Monitor *mon, const QDict *qdict)
-    IOAPICCommonState s;
+    IOAPICCommonState *s = IOAPIC_COMMON(object_resolve_path("ioapic", NULL));
-    kvm_ioapic_get(&s);
-    ioapic_print_redtbl(mon, &s);
+    assert(s);
+    kvm_ioapic_get(s);
+    ioapic_print_redtbl(mon, s);
 static void kvm_ioapic_reset(DeviceState *dev)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]