[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi ra
Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D
Fri, 17 Feb 2017 15:52:16 +0000
On 17 February 2017 at 15:50, Eric Blake <address@hidden> wrote:
> On 02/17/2017 09:12 AM, Peter Maydell wrote:
>> Unfortunately some older versions of makeinfo don't correctly
>> handle the -D command line option and fail to set the variable.
>> This then causes them to complain
>> docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION
>> Work around this by doing as the autotools do, and writing
>> the information into a version.texi file which we then
>> include from the .texi files that need it.
> Autotools defines a few more macros, but we can always beef up our
> version.texi if we find ourselves needing any of them.
>> Signed-off-by: Peter Maydell <address@hidden>
>> Makefile | 17 ++++++++++-------
>> docs/qemu-ga-ref.texi | 2 ++
>> docs/qemu-qmp-ref.texi | 2 ++
>> 3 files changed, 14 insertions(+), 7 deletions(-)
> Missing a change to .gitignore for version.texi.
@@ -107,6 +107,7 @@ docs/qemu-ga-ref.info*