[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate |
Date: |
Fri, 17 Feb 2017 21:15:54 +0100 |
Done with this Coccinelle semantic patch:
@@
expression E;
@@
- g_assert(E);
- error_free(E);
+ error_free_or_abort(&E);
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/test-qemu-opts.c | 3 +--
tests/test-qobject-output-visitor.c | 6 ++----
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/tests/test-qemu-opts.c b/tests/test-qemu-opts.c
index a505a3e..d08e8a6 100644
--- a/tests/test-qemu-opts.c
+++ b/tests/test-qemu-opts.c
@@ -79,8 +79,7 @@ static void test_find_unknown_opts(void)
/* should not return anything, we don't have an "unknown" option */
list = qemu_find_opts_err("unknown", &err);
g_assert(list == NULL);
- g_assert(err);
- error_free(err);
+ error_free_or_abort(&err);
}
static void test_qemu_find_opts(void)
diff --git a/tests/test-qobject-output-visitor.c
b/tests/test-qobject-output-visitor.c
index 4e2d79c..58019e2 100644
--- a/tests/test-qobject-output-visitor.c
+++ b/tests/test-qobject-output-visitor.c
@@ -146,8 +146,7 @@ static void
test_visitor_out_enum_errors(TestOutputVisitorData *data,
for (i = 0; i < ARRAY_SIZE(bad_values) ; i++) {
err = NULL;
visit_type_EnumOne(data->ov, "unused", &bad_values[i], &err);
- g_assert(err);
- error_free(err);
+ error_free_or_abort(&err);
visitor_reset(data);
}
}
@@ -251,8 +250,7 @@ static void
test_visitor_out_struct_errors(TestOutputVisitorData *data,
u.has_enum1 = true;
u.enum1 = bad_values[i];
visit_type_UserDefOne(data->ov, "unused", &pu, &err);
- g_assert(err);
- error_free(err);
+ error_free_or_abort(&err);
visitor_reset(data);
}
}
--
2.7.4
- [Qemu-devel] [PATCH] tests: Use error_free_or_abort() where appropriate,
Markus Armbruster <=