[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recur
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some |
Date: |
Fri, 17 Feb 2017 21:38:14 +0100 |
Consistently check for unexpected QDict entries, and qdict_get_qdict()
success. The latter doesn't tighten the test, it only makes it fail
more nicely.
Signed-off-by: Markus Armbruster <address@hidden>
---
tests/check-qdict.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/check-qdict.c b/tests/check-qdict.c
index 14e942a..ded3a26 100644
--- a/tests/check-qdict.c
+++ b/tests/check-qdict.c
@@ -615,26 +615,31 @@ static void qdict_crumple_test_recursive(void)
vnc = qdict_get_qdict(dst, "vnc");
g_assert(vnc);
+ g_assert_cmpint(qdict_size(vnc), ==, 3);
listen = qdict_get_qdict(vnc, "listen");
g_assert(listen);
+ g_assert_cmpint(qdict_size(listen), ==, 2);
g_assert_cmpstr("127.0.0.1", ==, qdict_get_str(listen, "addr"));
g_assert_cmpstr("5901", ==, qdict_get_str(listen, "port"));
acl = qdict_get_qdict(vnc, "acl");
g_assert(acl);
+ g_assert_cmpint(qdict_size(acl), ==, 3);
rules = qdict_get_qlist(acl, "rules");
g_assert(rules);
g_assert_cmpint(qlist_size(rules), ==, 2);
rule = qobject_to_qdict(qlist_pop(rules));
+ g_assert(rule);
g_assert_cmpint(qdict_size(rule), ==, 2);
g_assert_cmpstr("fred", ==, qdict_get_str(rule, "match"));
g_assert_cmpstr("allow", ==, qdict_get_str(rule, "policy"));
QDECREF(rule);
rule = qobject_to_qdict(qlist_pop(rules));
+ g_assert(rule);
g_assert_cmpint(qdict_size(rule), ==, 2);
g_assert_cmpstr("bob", ==, qdict_get_str(rule, "match"));
g_assert_cmpstr("deny", ==, qdict_get_str(rule, "policy"));
--
2.7.4
- [Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat(), (continued)
- [Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some,
Markus Armbruster <=
- [Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 04/14] check-qjson: Simplify around compare_litqobj_to_qobj(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 08/14] tests: Don't check qobject_type() before qobject_to_qlist(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 14/14] block: Don't bother asserting type of output visitor's output, Markus Armbruster, 2017/02/17