[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz()
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz() |
Date: |
Fri, 17 Feb 2017 14:48:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/14/2017 04:26 AM, Markus Armbruster wrote:
> Most callers of qemu_strtosz_suffix() pass QEMU_STRTOSZ_DEFSUFFIX_B.
> Capture the pattern in new qemu_strtosz().
>
> Inline qemu_strtosz_suffix() into its only remaining caller.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> +++ b/util/cutils.c
> @@ -178,6 +178,14 @@ int fcntl_setfl(int fd, int flag)
> }
> #endif
>
> +#define QEMU_STRTOSZ_DEFSUFFIX_EB 'E'
> +#define QEMU_STRTOSZ_DEFSUFFIX_PB 'P'
> +#define QEMU_STRTOSZ_DEFSUFFIX_TB 'T'
> +#define QEMU_STRTOSZ_DEFSUFFIX_GB 'G'
> +#define QEMU_STRTOSZ_DEFSUFFIX_MB 'M'
> +#define QEMU_STRTOSZ_DEFSUFFIX_KB 'K'
> +#define QEMU_STRTOSZ_DEFSUFFIX_B 'B'
5/7 of these #defines are useless, now that all callers are limited to
file scope.
With that cleaned up,
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH 02/24] QemuOpts: Assert value string isn't null, (continued)
- [Qemu-devel] [PATCH 07/24] util/cutils: Clean up variable names around qemu_strtol(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 15/24] util/cutils: Rename qemu_strtosz() to qemu_strtosz_mebi(), Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz(), Markus Armbruster, 2017/02/14
- Re: [Qemu-devel] [PATCH 16/24] util/cutils: New qemu_strtosz(),
Eric Blake <=
- [Qemu-devel] [PATCH 23/24] util/cutils: Change qemu_strtosz*() from int64_t to uint64_t, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 04/24] tests/test-cutils: Clean up qemu_strtoul() result checks, Markus Armbruster, 2017/02/14
- [Qemu-devel] [PATCH 06/24] util/cutils: Rename qemu_strtoll(), qemu_strtoull(), Markus Armbruster, 2017/02/14