[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new bloc

From: Ketan Nilangekar
Subject: Re: [Qemu-devel] [PATCH v8 1/2] block/vxhs.c: Add support for a new block device type called "vxhs"
Date: Sat, 18 Feb 2017 00:30:31 +0000
User-agent: Microsoft-MacOutlook/f.1c.1.161117

On 2/17/17, 1:42 PM, "Jeff Cody" <address@hidden> wrote:

    On Thu, Feb 16, 2017 at 02:24:19PM -0800, ashish mittal wrote:
    > Hi,
    > I am getting the following error with checkpatch.pl
    > ERROR: externs should be avoided in .c files
    > #78: FILE: block/vxhs.c:28:
    > +QemuUUID qemu_uuid __attribute__ ((weak));
    > Is there any way to get around this, or does it mean that I would have
    > to add a vxhs.h just for this one entry?
    I remain skeptical on the use of the qemu_uuid as a way to select the TLS

Is there another identity that can be used for uniquely identifying instances?
The requirement was to enforce vdisk access to owner instances.

    But that aside, and looking at it strictly from a checkpatch.pl point of
    view, I think one could make a case that if there is no header file, the
    error could be ignored.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]