[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strto
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz() |
Date: |
Sat, 18 Feb 2017 11:13:40 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/14/2017 04:26 AM, Markus Armbruster wrote:
>> Cc: Kevin Wolf <address@hidden>
>> Cc: Max Reitz <address@hidden>
>> Cc: address@hidden
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> qemu-img.c | 58 +++++++++++++++++++++++++++++++---------------------------
>> 1 file changed, 31 insertions(+), 27 deletions(-)
>
>
>> @@ -3858,11 +3866,9 @@ static int img_dd_count(const char *arg,
>> struct DdIo *in, struct DdIo *out,
>> struct DdInfo *dd)
>> {
>> - char *end;
>> + dd->count = cvtnum(arg);
>
> Hmm. cvtnum() accepts "1.5G", GNU dd does not. POSIX requires dd to
> accept '1kx10k' to mean 10 mebibytes, and GNU dd accepts '10xM' as a
> synonym, but cvtnum() does not accept all those corner cases. POSIX
> requires dd to treat '1b' as '512', while cvdnum() treats it as '1'. I
> sometimes wonder if our 'qemu-img dd' subcommand should be reusing the
> numeric parsing that we use everywhere else, in spite of it meaning that
> we are different than the POSIX quirks on what numbers are required to
> be supported by dd.
qemu-img dd falls short of its stated goal to be like /usr/bin/dd.
Whether that's good or bad I decline to judge ;)
> But that's not the concern of this patch.
Yes.
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- Re: [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit, (continued)
Re: [Qemu-devel] [PATCH 08/24] util/cutils: Clean up control flow around qemu_strtol() a bit, Eric Blake, 2017/02/14
[Qemu-devel] [PATCH 13/24] tests/test-cutils: Cover qemu_strtosz() around range limits, Markus Armbruster, 2017/02/14
[Qemu-devel] [PATCH 24/24] QemuOpts: Fix checking of sizes for overflow and trailing crap, Markus Armbruster, 2017/02/14
[Qemu-devel] [PATCH 20/24] qemu-img: Wrap cvtnum() around qemu_strtosz(), Markus Armbruster, 2017/02/14
[Qemu-devel] [PATCH 21/24] util/cutils: Let qemu_strtosz*() optionally reject trailing crap, Markus Armbruster, 2017/02/14
[Qemu-devel] [PATCH 22/24] util/cutils: Return qemu_strtosz*() error and value separately, Markus Armbruster, 2017/02/14