[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] risu-m68k: update fpregs

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH] risu-m68k: update fpregs
Date: Mon, 20 Feb 2017 13:17:48 +0000

On 20 February 2017 at 13:08, Laurent Vivier <address@hidden> wrote:
> Le 20/02/2017 à 13:49, Peter Maydell a écrit :
>> Oops, that was unintended. We definitely don't want to require
>> decorating all the function calls in the .risu files. Reverting
>> commit 6a3647ae8918 should fix this, but I'll see if there's
>> a way to avoid the code duplication without the problem with
>> evaluation happening in the "wrong" module scope.
> Reverting 6a3647ae8918 actually fixes the problem.

I found a better fix (adding a package statement to the eval'd
string) and pushed it to master.

The ideal solution to this problem would be to tighten up the
way we evaluate strings from risu files, so that they're run
in their own package which only has imported into it the specific
functions that we want to give them access to. That's a bit
beyond my somewhat rudimentary Perl skills though, so I've
settled for just adding a comment to that effect.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]