[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] spice-char: fix segfault in char_spice_finalize

From: Li Qiang
Subject: [Qemu-devel] [PATCH] spice-char: fix segfault in char_spice_finalize
Date: Mon, 20 Feb 2017 19:37:19 -0800

In 'qemu_chr_open_spice_vmc' if the 'psubtype' is NULL, it will
call 'char_spice_finalize'. But as the SpiceChardev is not inserted
in the 'spice_chars' list, the 'QLIST_REMOVE' will cause a segfault.
Add a detect to avoid it.

Signed-off-by: Li Qiang <address@hidden>
 spice-qemu-char.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/spice-qemu-char.c b/spice-qemu-char.c
index 6f46f46..15dbf9c 100644
--- a/spice-qemu-char.c
+++ b/spice-qemu-char.c
@@ -215,7 +215,10 @@ static void char_spice_finalize(Object *obj)
     SpiceChardev *s = SPICE_CHARDEV(obj);
-    QLIST_REMOVE(s, next);
+    if (spice_chars.lh_first) {
+        QLIST_REMOVE(s, next);
+    }
     g_free((char *)s->sin.subtype);
 #if SPICE_SERVER_VERSION >= 0x000c02

reply via email to

[Prev in Thread] Current Thread [Next in Thread]