[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH] vga: wire up -g <width>x<height> switch for
Re: [Qemu-devel] [RfC PATCH] vga: wire up -g <width>x<height> switch for virtio and qxl
Tue, 21 Feb 2017 15:42:20 +0100
> I think the basic idea of the patch is good, but I'd remove the qxl
> FIXMEs for the final version of the patch (spice is likely not working
> on Sparc and PPC anyway yet).
Sure, just wanted have a rfc out of the door before going debug the qxl
> > -#ifdef TARGET_SPARC
> > +#if defined(TARGET_SPARC)
> > int graphic_width = 1024;
> > int graphic_height = 768;
> > int graphic_depth = 8;
> > -#else
> > +#elif defined(TARGET_PPC)
> > int graphic_width = 800;
> > int graphic_height = 600;
> > int graphic_depth = 32;
> > +#else
> > +int graphic_width;
> > +int graphic_height;
> > +int graphic_depth;
> > #endif
> IMHO we could also switch the default resolution on ppc to 1024x768, so
> you could simplify that code to something like that:
Cc'ing qemu-ppc list. Comments on the suggestion?
> And maybe Sparc can even work fine with 32 bpp nowadays, too, so you
> could completely get rid of the ifdefery here?
Depends on the sparc display devices, so no for the general case.
I think the better policy would be to just not initialize the graphics_*
variables and let the machine and/or display adapter pick a sane default