[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] ARM i.MX timers: fix software reset

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v3] ARM i.MX timers: fix software reset
Date: Tue, 21 Feb 2017 14:47:14 +0000

On 19 February 2017 at 19:00, Kurban Mallachiev <address@hidden> wrote:
> Hello!
> Problem: function imx_gpt_reset is used for soft (requested by guest) and
> hard resets. But soft and hard resets should have different behaviour (hard
> reset should clear all registers, while soft reset should preserve some
> bits).
> Patch changelog:
> v1 -> v2: use different approach, patch completely rewritten
> v2 -> v3: in software reset add preserving of CLKSRC bit as manual says
> ---
> Software reset function clears CR bits that should not be cleared and
> preserve bits that should be cleared.
> Signed-off-by: Kurban Mallachiev <address@hidden>

Thanks for this patch -- I have added it to my target-arm queue
(with a few tweaks).

Unfortunately your mail client mangled the patch a bit, and I had
to apply it manually. I'm happy to do that for occasional contributions,
but if you're planning to submit a lot of patches in the near future
you might like to look at your patch submission workflow (we usually
recommend 'git send-email').

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]