[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/2] vfio/platform: make the vfio-platform devic

From: Auger Eric
Subject: Re: [Qemu-devel] [PATCH 1/2] vfio/platform: make the vfio-platform device non abstract
Date: Tue, 21 Feb 2017 15:59:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0

Hi Sinan,
On 21/02/2017 15:45, Sinan Kaya wrote:
> Hi Eric,
> Thanks for the long anticipated patch.
> On 2/21/2017 8:18 AM, Eric Auger wrote:
>> +    DEFINE_PROP_STRING("manufacturer", VFIOPlatformDevice, manufacturer),
>> +    DEFINE_PROP_STRING("model", VFIOPlatformDevice, model),
> The OF string is not always of the format "manufacturer, model".
> HIDMA for instance uses a syntax of "qcom, hidma-1.0" and "qcom, hidma-2.0".
> This syntax is used for cases where an IP gets used in multiple SOCs. 
> Maybe, we should call it just compatible-string and try not to make meaning
> out of it.
> Sinan

in  http://www.devicetree.org/specifications-pdf I found the description
at the bottom.

I your case what would prevent from creating 2 entries in the table and
then use either in qemu cmd line?

VFIO_PLATFORM_BINDING("qcom", "hidma-1.0", add_amd_hidma_fdt_node),
VFIO_PLATFORM_BINDING("qcom", "hidma-2.0", add_amd_hidma_fdt_node),

The issue is the comma in the property is interpreted as a separator for
options, hence that choice of having 2 separate options.

Besides I will fix the CONFIG_LINUX compilation issue asap.



The recommended format is "manufacturer,model", where manufacturer is a
string describing the name of the manufacturer (such as a stock ticker
symbol), and model specifies the model number.

compatible = "fsl,mpc8641-uart", "ns16550";
In this example, an operating system would first try to locate a device
driver that supported
fsl,mpc8641-uart. If a driver was not found, it would then try to locate
a driver that supported the more general ns16550 device type.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]