[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint() |
Date: |
Tue, 21 Feb 2017 13:18:43 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/17/2017 02:38 PM, Markus Armbruster wrote:
> qobject_to_qint(obj) returns NULL when obj isn't a QInt. Check
> that instead of qobject_type(obj) == QTYPE_QINT.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> tests/check-qjson.c | 24 +++++-------------------
> tests/test-qobject-output-visitor.c | 28 ++++++++++++----------------
> 2 files changed, 17 insertions(+), 35 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict(), (continued)
- [Qemu-devel] [PATCH 01/14] qdict: Make qdict_get_qlist() safe like qdict_get_qdict(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 02/14] check-qdict: Simplify qdict_crumple_test_recursive(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 11/14] tests: Don't check qobject_type() before qobject_to_qfloat(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 06/14] test-qmp-event: Simplify and tighten event_test_emit(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(), Markus Armbruster, 2017/02/17
- Re: [Qemu-devel] [PATCH 10/14] tests: Don't check qobject_type() before qobject_to_qint(),
Eric Blake <=
- [Qemu-devel] [PATCH 07/14] Don't check qobject_type() before qobject_to_qdict(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 09/14] tests: Don't check qobject_type() before qobject_to_qstring(), Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 03/14] check-qdict: Tighten qdict_crumple_test_recursive() some, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 13/14] monitor: Clean up handle_hmp_command() a bit, Markus Armbruster, 2017/02/17
- [Qemu-devel] [PATCH 05/14] libqtest: Clean up qmp_response() a bit, Markus Armbruster, 2017/02/17