[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] virtio: add missing region cache init in vi
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] virtio: add missing region cache init in virtio_load() |
|
Date: |
Wed, 22 Feb 2017 11:19:45 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 22/02/2017 10:16, Cornelia Huck wrote:
>> +
>> + /* All ring addresses have been loaded now... */
>> + virtio_init_region_cache(vdev, i);
> It feels a bit weird that the region cache was already initialized when
> update rings was called. Should the call to init_region_cache be moved
> from update_rings() to virtio_queue_set_addr()?
virtio_queue_set_addr isn't called at all, is it?
The alternative would be to call virtio_init_region_cache from a
postload callback of vmstate_virtqueue, but Stefan's patch is fine too IMHO.
Paolo