[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/3] i386/cpu: net: Flatten simple union Gues

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 3/3] i386/cpu: net: Flatten simple union GuestPanicInformationType
Date: Wed, 22 Feb 2017 09:14:32 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/21/2017 02:46 PM, Markus Armbruster wrote:
> Simple unions are simpler than flat unions in the schema, but more
> complicated in C and on the QMP wire: there's extra indirection in C
> and extra nesting on the wire, both pointless.  They're best avoided
> in new code.  Fix up recent commit d187e08 accordingly.
> Cc: Anton Nefedov <address@hidden>
> Cc: Denis V. Lunev <address@hidden>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  qapi-schema.json  | 14 ++++++++++++--
>  target/i386/cpu.c | 17 ++++++-----------
>  vl.c              | 12 ++++++------
>  3 files changed, 24 insertions(+), 19 deletions(-)

Very similar to Anton's patch which is on Paolo's queue:

I don't care which version goes in, but will leave it to Markus and
Paolo to decide which queue it should go through.

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]