[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 02/15] colo-compare: implement the process of ch

From: Zhang Chen
Subject: Re: [Qemu-devel] [PATCH 02/15] colo-compare: implement the process of checkpoint
Date: Thu, 23 Feb 2017 13:49:26 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 02/23/2017 09:02 AM, Hailiang Zhang wrote:

On 2017/2/22 17:31, Zhang Chen wrote:

On 02/22/2017 11:42 AM, zhanghailiang wrote:
While do checkpoint, we need to flush all the unhandled packets,
By using the filter notifier mechanism, we can easily to notify
every compare object to do this process, which runs inside
of compare threads as a coroutine.

Hi~ Jason and Hailiang.

I will send a patch set later about colo-compare notify mechanism for
Xen like this patch.
I want to add a new chardev socket way in colo-comapre connect to Xen
colo, for notify
checkpoint or failover, Because We have no choice to use this way
communicate with Xen codes.
That's means we will have two notify mechanism.
What do you think about this?

I don't think you need another mechanism, what you need to do is to
realize a qmp command which calls colo_notify_compares_event(),
It will not  return until the event (checkpoint or failover) be
handled by all compares. Will this satisfy your requirement ?

No, colo-frame notify colo-comapre can calls colo_notify_compares_event(),
That's OK, but colo-comapre notify colo-frame in Xen have some problem,
Xen's colo-frame needs a API that blocking and have a timeout to read colo-comapre's
notify, this timeout is the time of periodic checkpoint. In this patch set,
colo-compare just call colo_compare_inconsistent_notify() to non-blocking notify. We can not realize a qmp command that Xen always polling that to get status of notify,
Qemu also can not accept to call qmp command for polling.

Zhang Chen


Zhang Chen

Cc: Jason Wang <address@hidden>
Signed-off-by: zhanghailiang <address@hidden>
Signed-off-by: Zhang Chen <address@hidden>
net/colo-compare.c | 72 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
   net/colo-compare.h | 20 +++++++++++++++
   2 files changed, 92 insertions(+)
   create mode 100644 net/colo-compare.h


Zhang Chen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]