[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argu
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument |
Date: |
Thu, 23 Feb 2017 16:46:55 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/23/2017 03:44 PM, Markus Armbruster wrote:
> The value of key 'arguments' must be a JSON object. qemu-ga neglects
> to check, and crashes. To reproduce, send
>
> { 'execute': 'guest-sync', 'arguments': [] }
>
> to qemu-ga.
>
> do_qmp_dispatch() uses qdict_get_qdict() to get the arguments. When
> not a JSON object, this gets a null pointer, which flows through the
> generated marshalling function to qobject_input_visitor_new(), where
> it fails the assertion. qmp_dispatch_check_obj() needs to catch this
> error.
>
> QEMU isn't affected, because it runs qmp_check_input_obj() first,
> which basically duplicates qmp_check_input_obj()'s checks, plus the
> missing one.
>
> Fix by copying the missing one from qmp_check_input_obj() to
> qmp_dispatch_check_obj().
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Cc: Michael Roth <address@hidden>
> ---
> qapi/qmp-dispatch.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/21] qapi: QMP dispatch and input visitor work, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 09/21] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 04/21] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 03/21] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/02/23
- Re: [Qemu-devel] [PATCH 01/21] qga: Fix crash on non-dictionary QMP argument,
Eric Blake <=
- [Qemu-devel] [PATCH 14/21] qapi: Make string input and opts visitor require non-null input, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 08/21] qmp: Improve QMP dispatch error messages, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 02/21] libqtest: Work around a "QMP wants a newline" bug, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 05/21] qmp: Clean up how we enforce capability negotiation, Markus Armbruster, 2017/02/23