[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 17/21] qapi: Drop unused non-strict qobject inpu
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH 17/21] qapi: Drop unused non-strict qobject input visitor |
|
Date: |
Fri, 24 Feb 2017 16:02:03 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Paolo Bonzini <address@hidden> writes:
> On 23/02/2017 22:45, Markus Armbruster wrote:
>> The split between tests/test-qobject-input-visitor.c and
>> tests/test-qobject-input-strict.c now makes less sense than ever. The
>> next commit will take care of that.
>
> I'm actually adding a use for non-strict visitors (and one that makes
> sense IMHO, with comments, testcases and all that :)). See
> https://www.mail-archive.com/address@hidden/msg432069.html.
I replied.
> For what it's worth, however, I believe that even non-strict visits
> should detect unvisited list tails.
Bit of an asymmetry. Not sure it matters, because to not visit list
tails, you have to put in some effort.
- Re: [Qemu-devel] [PATCH 13/21] qapi: Drop string input visitor method optional(), (continued)
- [Qemu-devel] [PATCH 21/21] qapi: Improve qobject visitor documentation, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 12/21] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 18/21] tests-qobject-input-strict: Merge into test-qobject-input-visitor, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 11/21] qapi: Make QObject input visitor set *list reliably, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 17/21] qapi: Drop unused non-strict qobject input visitor, Markus Armbruster, 2017/02/23
Re: [Qemu-devel] [PATCH 00/21] qapi: QMP dispatch and input visitor work, no-reply, 2017/02/24