|
| From: | Michal Marek |
| Subject: | Re: [Qemu-devel] [PATCH] target-s390x: Implement stfl and stfle |
| Date: | Fri, 24 Feb 2017 16:22:57 +0100 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 |
On 2017-02-24 15:51, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
[...]
> === OUTPUT BEGIN ===
> Checking PATCH 1/1: target-s390x: Implement stfl and stfle...
> ERROR: braces {} are necessary for all arms of this statement
> #108: FILE: target/s390x/misc_helper.c:522:
> + if (need <= len)
> [...]
> + else
> [...]
I was not aware of this coding style requirement. I will wait if I get
more feedback from humans and resubmit.
Michal
| [Prev in Thread] | Current Thread | [Next in Thread] |