[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/29] 9pfs: introduce openat_nofollow() helper
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 04/29] 9pfs: introduce openat_nofollow() helper |
Date: |
Fri, 24 Feb 2017 23:17:44 +0100 |
On Fri, 24 Feb 2017 17:17:30 +0000
Stefan Hajnoczi <address@hidden> wrote:
[...]
> > > This function doesn't handle absolute paths? It ignores leading '/' and
> > > therefore treats all paths as relative paths.
> > >
> >
> > Yes because any path coming from the client is supposed (*) to be relative
> > to the
> > shared directory and openat(2) says:
>
> Please change the function name since this isn't openat with nofollow
> behavior, it's a subset of openat that only takes relative paths with
> nofollow behavior.
In the v2, this function is only called by local_open_nofollow() actually.
Maybe I should move the stripping of leading '/' characters there ?
pgpxQ0YzdaHb_.pgp
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 01/29] 9pfs: local: move xattr security ops to 9p-xattr.c, (continued)
[Qemu-devel] [PATCH 05/29] 9pfs: local: keep a file descriptor on the shared folder, Greg Kurz, 2017/02/20
[Qemu-devel] [PATCH 06/29] 9pfs: local: open/opendir: don't follow symlinks, Greg Kurz, 2017/02/20
[Qemu-devel] [PATCH 07/29] 9pfs: local: introduce symlink-attack safe xattr helpers, Greg Kurz, 2017/02/20