[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH V9 2/2] Add a new qmp command to do checkpoint,

From: Zhang Chen
Subject: Re: [Qemu-devel] [PATCH V9 2/2] Add a new qmp command to do checkpoint, query xen replication status
Date: Sat, 25 Feb 2017 10:33:18 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1

On 02/25/2017 01:27 AM, Eric Blake wrote:
On 02/24/2017 01:22 AM, Zhang Chen wrote:
We can call this qmp command to do checkpoint outside of qemu.
Xen colo will need this function.

Signed-off-by: Zhang Chen <address@hidden>
Signed-off-by: Wen Congyang <address@hidden>
  migration/colo.c | 23 +++++++++++++++++++++++
  qapi-schema.json | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
  2 files changed, 72 insertions(+)

+++ b/qapi-schema.json
@@ -5931,6 +5931,55 @@
    'data': { 'enable': 'bool', 'primary': 'bool', '*failover' : 'bool' } }
+# @ReplicationStatus:
+# The result format for 'query-xen-replication-status'.
+# @error: true to error, false to normal.

true if an error happened, false if replication is normal

Maintainer could touch that up during application, so it doesn't
necessarily require a v10.

Maintainer may be very busy, I will do this fix in V10.

+# @query-xen-replication-status:
+# Query replication status while the vm is running.
+# Returns: A @ReplicationResult object showing the status.
+# Example:
+# -> { "execute": "query-xen-replication-status" }
+# <- { "return": [ { "error": false },
+#                  { "error": true } ] }
This example is bogus.  The command does NOT return an array.  It is
sufficient to use:

{ "return": { "error": false } }

but if you want, you could instead do:

{ "return": { "error": true, "desc": "..." } }

but if you do that, please be sure that desc matches an actual error
code that could occur, and not something made up.

If all you do is fix the example with the simpler "error":false (and
maybe the maintainer is okay doing that), then you can add:
Reviewed-by: Eric Blake <address@hidden>

I will fix the example in V10, and which maintainer can pick up this patch?

Zhang Chen

Zhang Chen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]