[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for
Re: [Qemu-devel] [PATCH v2] linux-user: Add signal handling support for x86_64
Sun, 26 Feb 2017 14:04:07 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
Le 26/02/2017 à 13:39, Peter Maydell a écrit :
> On 26 February 2017 at 12:29, Laurent Vivier <address@hidden> wrote:
>> Le 26/02/2017 à 00:04, Pranith Kumar a écrit :
>>> Note that x86_64 has only _rt signal handlers. This implementation
>>> attempts to share code with the x86_32 implementation.
>>> + struct target_fpreg st;
>> Why don't you keep the original name "_st"?
> I suspect I asked for that in an earlier round of review
> on the basis that names with underscores are reserved
> namespace. Looking more closely at the rules though that's
> a bit over-conservative for a struct field name because
> _ followed by lowercase is only reserved in the global
> name space (unlike __ or _ followed by uppercase, which
> could be a macro). So using _st here isn't wrong, but
> on the other hand there's not much reason to use the
> underscore I think.
OK, thanks for the explanation.