[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 16/21] test-qobject-input-visitor: Use strict vi
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH 16/21] test-qobject-input-visitor: Use strict visitor |
Date: |
Mon, 27 Feb 2017 06:35:04 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 02/23/2017 03:45 PM, Markus Armbruster wrote:
>> The qobject input visitor comes in a strict and a non-strict variant.
>> This test is the non-strict variant's last user.
>
> Well, depending on Paolo's proposed addition.
Needs a commit message tweak if Paolo's goes in first.
>> Turns out it relies
>> on non-strict only in test_visitor_in_null(), and just out of
>> laziness. We don't actually test the non-strict behavior.
>>
>> Clean up test_visitor_in_null(), and switch to the strict variant.
>> The next commit will drop the non-strict variant.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>> tests/test-qobject-input-visitor.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> I'm in favor of unifying the two tests into one and reducing the
> duplication (this and the next patch), whether or not we decide that
Patch after next, actually.
> Paolo's patch means we don't want to eliminate non-strict mode.
>
> Reviewed-by: Eric Blake <address@hidden>
Thanks!
- [Qemu-devel] [PATCH 08/21] qmp: Improve QMP dispatch error messages, (continued)
- [Qemu-devel] [PATCH 08/21] qmp: Improve QMP dispatch error messages, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 02/21] libqtest: Work around a "QMP wants a newline" bug, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 05/21] qmp: Clean up how we enforce capability negotiation, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 16/21] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 07/21] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 06/21] qmp: Drop duplicated QMP command object checks, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 20/21] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 15/21] qom: Make object_property_set_qobject()'s input visitor strict, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 19/21] tests: Cover partial input visit of list, Markus Armbruster, 2017/02/23
- [Qemu-devel] [PATCH 10/21] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/02/23