[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend d
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend data with prealloc |
Date: |
Mon, 27 Feb 2017 13:28:35 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Fri, Feb 24, 2017 at 05:27:14PM +0000, Daniel P. Berrange wrote:
> When using a memory-backend object with prealloc turned on, QEMU
> will memset() the first byte in every memory page to zero. While
> this might have been acceptable for memory backends associated
> with RAM, this corrupts application data for NVDIMMs.
>
> Instead of setting every page to zero, read the current byte
> value and then just write that same value back, so we are not
> corrupting the original data. Directly write the value instead
> of memset()ing it, since there's no benefit to memset for a
> single byte write.
>
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
>
> NB, I have not tested performance of this, so no idea if this
> makes it better/worse/no-change. Would appreciate if Jitendra
> could repeat tests to see if it impacts scalability at all.
>
> util/oslib-posix.c | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <address@hidden>
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend data with prealloc, (continued)
Re: [Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend data with prealloc, Stefan Hajnoczi, 2017/02/27
[Qemu-devel] [PATCH] os: don't corrupt pre-existing memory-backend data with prealloc, Daniel P. Berrange, 2017/02/24