[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/5] migration/vmstate: fix array of ptr with
Re: [Qemu-devel] [PATCH v2 3/5] migration/vmstate: fix array of ptr with nullptrs
Mon, 27 Feb 2017 15:02:17 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0
On 02/24/2017 01:29 PM, Dr. David Alan Gilbert wrote:
> * Halil Pasic (address@hidden) wrote:
>> Make VMS_ARRAY_OF_POINTER cope with null pointers. Previously the
>> reward for trying to migrate an array with some null pointers in it was
>> an illegal memory access, that is a swift and painless death of the
>> process. Let's make vmstate cope with this scenario.
>> The general approach is, when we encounter a null pointer (element),
>> instead of following the pointer to save/load the data behind it, we
>> save/load a placeholder. This way we can detect if we expected a null
>> pointer at the load side but not null data was saved instead.
>> Signed-off-by: Halil Pasic <address@hidden>
>> Reviewed-by: Guenther Hutzl <address@hidden>
> Reviewed-by: Dr. David Alan Gilbert <address@hidden>
Thanks! Seems there are no further objections. Is the series going in
via your tree (softfreeze starting 28.02, me worried)?