[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PULL v2 00/17] KVM and cpu-exec patches for 2.9 soft f

From: Peter Maydell
Subject: Re: [Qemu-devel] [PULL v2 00/17] KVM and cpu-exec patches for 2.9 soft freeze
Date: Mon, 27 Feb 2017 14:37:51 +0000

On 27 February 2017 at 12:45, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit d992f2f1368ceb92e6bfd8efece174110f4236ff:
>   Merge remote-tracking branch 'remotes/artyom/tags/pull-sun4v-20170226' into 
> staging (2017-02-26 22:40:23 +0000)
> are available in the git repository at:
>   git://github.com/bonzini/qemu.git tags/for-upstream
> for you to fetch changes up to f601681feff62113b526d4ad491af4a03aca825a:
>   qmp-events: fix GUEST_PANICKED description formatting (2017-02-27 13:31:25 
> +0100)
> v1->v2: add missing #ifdef KVM_HAVE_MCE_INJECTION
>         rebase over MTTCG pull request.  -icount is currently broken but
>         I'd like to preserve bisectability, so this pull request brings
>         in the icount patches through a merge commit.
> ----------------------------------------------------------------
> * kernel header update (requested by David and Vijay)
> * GuestPanicInformation fixups (Anton)
> * record/replay icount fixes (Pavel)
> * cpu-exec cleanup, unification of icount_decr with tcg_exit_req (me)
> * KVM_CAP_IMMEDIATE_EXIT support (me)
> * vmxcap update (me)

Build failures :-(

/Users/pm215/src/qemu-for-merges/util/oslib-posix.c:634:35: error: use
of undeclared identifier 'SIGPOLL'
    } else if (info->ssi_signo == SIGPOLL) {

There's no SIGPOLL on OSX, apparently (it is marked as obsolescent
in the POSIX spec). The sys/signal.h header only defines a SIGPOLL if
(defined(_POSIX_C_SOURCE) && !defined(_DARWIN_C_SOURCE)) (ie you
asked for the POSIX, the whole POSIX and nothing but the POSIX).
There is a SIGIO (which is defined if the exact opposite condition
is true).

PPC64, AArch64, ARM:

/home/pm215/qemu/kvm-all.c:1898:23: error: ‘pending_sigbus_addr’
defined but not used [-Werror=unuse
 static __thread void *pending_sigbus_addr;
/home/pm215/qemu/kvm-all.c:1899:21: error: ‘pending_sigbus_code’
defined but not used [-Werror=unuse
 static __thread int pending_sigbus_code;

Incidentally, trying to figure out which fields in a siginfo_t
should be valid is a losing game (though one we play elsewhere,
see host_to_target_siginfo_noswap() in linux-user), because
the si_code/signal doesn't actually tell you which fields are valid
given the existence of rt_sigqueueinfo(). (The kernel internally
is OK because it has the high 16 bits of si_code, but at least
for a real signal handler it doesn't tell userspace those high
bits, so userspace can't distinguish a spoofed si_code (which
has si_pid/si_uid) from a real one (has addr/band/timer/etc
depending on the code). Maybe signalfd() gives you the full
si_code; I haven't checked...

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]