[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method optional() |
Date: |
Mon, 27 Feb 2017 10:46:22 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 |
On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> visit_optional() is to be called only between visit_start_struct() and
> visit_end_struct(). Visitors that don't support struct visits,
> i.e. don't implement start_struct(), end_struct(), have no use for it.
> Clarify documentation.
>
> The string input visitor doesn't support struct visits. Its
> parse_optional() is therefore useless. Drop it.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> include/qapi/visitor-impl.h | 4 ++--
> qapi/string-input-visitor.c | 13 -------------
> 2 files changed, 2 insertions(+), 15 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 00/26] qapi: QMP dispatch and input visitor work, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 08/26] qmp: Improve QMP dispatch error messages, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 01/26] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 11/26] qapi: Make QObject input visitor set *list reliably, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 02/26] libqtest: Work around a "QMP wants a newline" bug, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method optional(), Markus Armbruster, 2017/02/26
- Re: [Qemu-devel] [PATCH v2 13/26] qapi: Drop string input visitor method optional(),
Eric Blake <=
- [Qemu-devel] [PATCH v2 22/26] test-qobject-input-visitor: Cover missing nested struct member, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 10/26] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 04/26] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 19/26] test-string-input-visitor: Tear down existing test automatically, Markus Armbruster, 2017/02/26
- [Qemu-devel] [PATCH v2 12/26] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/02/26