[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display control
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation |
Date: |
Mon, 27 Feb 2017 19:03:45 +0000 |
On 27 February 2017 at 18:11, Michael Tokarev <address@hidden> wrote:
> 26.02.2017 03:17, BALATON Zoltan wrote:
>> Second try, addressing review comments.
>
> So.. I'm not sure what to do with this :)
>
> I can apply it to -trivial, but this smells a bit unfair
> on my side, while on the other hand, is there any more
> appropriate tree?
I think it's a bit of a stretch to argue that
"1089 insertions(+), 741 deletions" is "trivial", but
the difficulty is that sh4 isn't really very maintained.
Since the purpose seems to be to improve ppc emulation
somehow it could perhaps go via the ppc tree, but I dunno.
I have said I'll try to review this (since I looked at
v1), but I don't think I'm going to get to this before the
softfreeze deadline, I'm afraid. If you want to go through
and review it all feel free -- you probably have as much
knowledge about sh4 and this device as I do :-)
thanks
-- PMM
- [Qemu-devel] [PATCH v2 14/14] ppc: Add SM501 device in config for ppc and ppcemb targets, (continued)
- [Qemu-devel] [PATCH v2 14/14] ppc: Add SM501 device in config for ppc and ppcemb targets, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 08/14] sm501: Fix hardware cursor, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 02/14] sm501: Use defines instead of constants where available, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 09/14] sm501: Misc clean ups, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 11/14] sm501: Add some more missing registers, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 04/14] sm501: Get rid of base address in draw_hwc_line, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 05/14] sm501: Add emulation of chip connected via PCI, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 01/14] sm501: Fixed code style and a few typos in comments, BALATON Zoltan, 2017/02/25
- [Qemu-devel] [PATCH v2 03/14] sm501: QOMify, BALATON Zoltan, 2017/02/25
- Re: [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation, Michael Tokarev, 2017/02/27
- Re: [Qemu-devel] [PATCH v2 00/14] Improvements for SM501 display controller emulation,
Peter Maydell <=