[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 2/4] hw/sd: add card-reparenting function

From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v3 2/4] hw/sd: add card-reparenting function
Date: Tue, 28 Feb 2017 13:58:49 +0000

On 24 February 2017 at 16:40, Clement Deschamps
<address@hidden> wrote:
> Provide a new function sdbus_reparent_card() in sd core for reparenting
> a card from a SDBus to another one.
> This function is required by the raspi platform, where the two SD
> controllers can be dynamically switched.
> Signed-off-by: Clement Deschamps <address@hidden>
> ---
>  hw/sd/core.c       | 30 ++++++++++++++++++++++++++++++
>  include/hw/sd/sd.h |  1 +
>  2 files changed, 31 insertions(+)

It turns out we got the logic wrong here -- it causes random
crashes on OSX, and this valgrind error on Linux:

==19695== Invalid read of size 8
==19695==    at 0x7DD59C: object_unparent (object.c:446)
==19695==    by 0x6E920A: sdbus_reparent_card (core.c:158)
==19695==    by 0x3ED0D5: bcm2835_gpio_reset (bcm2835_gpio.c:268)
==19695==    by 0x5DE10E: device_reset (qdev.c:1148)
==19695==    by 0x5DBFA3: qdev_reset_one (qdev.c:295)
==19695==    by 0x5DCBA7: qdev_walk_children (qdev.c:610)
==19695==    by 0x5E0D4A: qbus_walk_children (bus.c:59)
==19695==    by 0x5DC0BD: qbus_reset_all (qdev.c:321)
==19695==    by 0x5DC0E0: qbus_reset_all_fn (qdev.c:327)
==19695==    by 0x5E1690: qemu_devices_reset (reset.c:69)
==19695==    by 0x5258C6: qemu_system_reset (vl.c:1695)
==19695==    by 0x52D915: main (vl.c:4645)
==19695==  Address 0x354c9bc0 is 0 bytes after a block of size 32 alloc'd
==19695==    at 0x4C2FB55: calloc (in
==19695==    by 0x1B7A5770: g_malloc0 (in
==19695==    by 0x5DB77C: bus_add_child (qdev.c:85)
==19695==    by 0x5DB8C9: qdev_set_parent_bus (qdev.c:107)
==19695==    by 0x5DBA17: qdev_try_create (qdev.c:153)
==19695==    by 0x5DB8EF: qdev_create (qdev.c:117)
==19695==    by 0x49E3AB: raspi2_init (raspi.c:152)
==19695==    by 0x52D68C: main (vl.c:4523)

I've dropped it (and the following patches) from the pull request
for the moment and will have a look at what the fix is.

-- PMM

reply via email to

[Prev in Thread] Current Thread [Next in Thread]