[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject i

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH v2 17/26] qapi: Drop unused non-strict qobject input visitor
Date: Tue, 28 Feb 2017 08:56:56 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 02/26/2017 03:43 PM, Markus Armbruster wrote:
> The split between tests/test-qobject-input-visitor.c and
> tests/test-qobject-input-strict.c now makes less sense than ever.  The
> next commit will take care of that.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

If I read Paolo's thread correctly, we were deferring his patches that
relied on a non-strict visit until 2.10.  And we can re-add non-strict
via a new constructor, rather than adding back a bool parameter to all
existing callers, so it doesn't hurt too badly that we are doing this
now for 2.9 (or a revert always works, if it is justified).

Reviewed-by: Eric Blake <address@hidden>

> @@ -276,7 +269,6 @@ static GenericList *qobject_input_next_list(Visitor *v, 
> GenericList *tail,
>      return tail->next;
>  }
> -
>  static void qobject_input_start_alternate(Visitor *v, const char *name,
>                                            GenericAlternate **obj, size_t 
> size,
>                                            bool promote_int, Error **errp)

Spurious hunk?

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]