[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28 |
Date: |
Tue, 28 Feb 2017 12:24:55 -0800 (PST) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Type: series
Subject: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
- [tag update] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
e9777e9 qapi: Improve qobject visitor documentation
dd9bf60 qapi: Fix object input visit beyond end of list
4443465 tests: Cover input visit beyond end of list
898d9e3 qapi: Make input visitors detect unvisited list tails
b6db608 test-qobject-input-visitor: Cover missing nested struct member
80757b0 tests: Cover partial input visit of list
fdae3b2 test-string-input-visitor: Improve list coverage
4fa58f6 test-string-input-visitor: Tear down existing test automatically
3aab16b tests-qobject-input-strict: Merge into test-qobject-input-visitor
83c83f8 qapi: Drop unused non-strict qobject input visitor
5854988 test-qobject-input-visitor: Use strict visitor
23da3ee qom: Make object_property_set_qobject()'s input visitor strict
67b3835 qapi: Make string input and opts visitor require non-null input
7948c3f qapi: Drop string input visitor method optional()
7e5ad00 qapi: Improve qobject input visitor error reporting
5be9196 qapi: Make QObject input visitor set *list reliably
979e388 qapi: Clean up after commit 3d344c2
9480410 qapi: Improve a QObject input visitor error message
b7e32a3 qmp: Improve QMP dispatch error messages
bbbd47c qmp: Eliminate silly QERR_QMP_* macros
62c12b7 qmp: Drop duplicated QMP command object checks
be68b6d qmp: Clean up how we enforce capability negotiation
ca7a5de qmp: Dumb down how we run QMP command registration
f412f0a qmp-test: New, covering basic QMP protocol
dd0679f libqtest: Work around a "QMP wants a newline" bug
4928e9c qga: Fix crash on non-dictionary QMP argument
=== OUTPUT BEGIN ===
Checking PATCH 1/26: qga: Fix crash on non-dictionary QMP argument...
Checking PATCH 2/26: libqtest: Work around a "QMP wants a newline" bug...
Checking PATCH 3/26: qmp-test: New, covering basic QMP protocol...
Checking PATCH 4/26: qmp: Dumb down how we run QMP command registration...
Checking PATCH 5/26: qmp: Clean up how we enforce capability negotiation...
Checking PATCH 6/26: qmp: Drop duplicated QMP command object checks...
Checking PATCH 7/26: qmp: Eliminate silly QERR_QMP_* macros...
Checking PATCH 8/26: qmp: Improve QMP dispatch error messages...
Checking PATCH 9/26: qapi: Improve a QObject input visitor error message...
Checking PATCH 10/26: qapi: Clean up after commit 3d344c2...
Checking PATCH 11/26: qapi: Make QObject input visitor set *list reliably...
Checking PATCH 12/26: qapi: Improve qobject input visitor error reporting...
Checking PATCH 13/26: qapi: Drop string input visitor method optional()...
Checking PATCH 14/26: qapi: Make string input and opts visitor require non-null
input...
Checking PATCH 15/26: qom: Make object_property_set_qobject()'s input visitor
strict...
Checking PATCH 16/26: test-qobject-input-visitor: Use strict visitor...
Checking PATCH 17/26: qapi: Drop unused non-strict qobject input visitor...
Checking PATCH 18/26: tests-qobject-input-strict: Merge into
test-qobject-input-visitor...
ERROR: line over 90 characters
#487: FILE: tests/test-qobject-input-visitor.c:847:
+ v = visitor_input_test_init(data, "{ 'integer': -42, 'boolean': true,
'string': 'foo', 'extra': 42 }");
ERROR: line over 90 characters
#501: FILE: tests/test-qobject-input-visitor.c:861:
+ v = visitor_input_test_init(data, "{ 'string0': 'string0', 'dict1': {
'string1': 'string1', 'dict2': { 'userdef1': { 'integer': 42, 'string':
'string', 'extra': [42, 23, {'foo':'bar'}] }, 'string2': 'string2'}}}");
ERROR: line over 90 characters
#515: FILE: tests/test-qobject-input-visitor.c:875:
+ v = visitor_input_test_init(data, "[ { 'string': 'string0', 'integer': 42
}, { 'string': 'string1', 'integer': 43 }, { 'string': 'string2', 'integer':
44, 'extra': 'ggg' } ]");
ERROR: line over 90 characters
#588: FILE: tests/test-qobject-input-visitor.c:948:
+ v = visitor_input_test_init(data, "{ 'string': 'c', 'integer': 41,
'boolean': true }");
WARNING: line over 80 characters
#595: FILE: tests/test-qobject-input-visitor.c:955:
+static void test_visitor_in_fail_union_flat_no_discrim(TestInputVisitorData
*data,
ERROR: line over 90 characters
#603: FILE: tests/test-qobject-input-visitor.c:963:
+ v = visitor_input_test_init(data, "{ 'integer': 42, 'string': 'c',
'string1': 'd', 'string2': 'e' }");
total: 5 errors, 1 warnings, 233 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 19/26: test-string-input-visitor: Tear down existing test
automatically...
Checking PATCH 20/26: test-string-input-visitor: Improve list coverage...
Checking PATCH 21/26: tests: Cover partial input visit of list...
Checking PATCH 22/26: test-qobject-input-visitor: Cover missing nested struct
member...
Checking PATCH 23/26: qapi: Make input visitors detect unvisited list tails...
Checking PATCH 24/26: tests: Cover input visit beyond end of list...
ERROR: if this code is redundant consider removing it
#86: FILE: tests/test-qobject-input-visitor.c:956:
+#if 0 /* FIXME crash */
total: 1 errors, 0 warnings, 95 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 25/26: qapi: Fix object input visit beyond end of list...
Checking PATCH 26/26: qapi: Improve qobject visitor documentation...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PULL 23/26] qapi: Make input visitors detect unvisited list tails, (continued)
- [Qemu-devel] [PULL 23/26] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 02/26] libqtest: Work around a "QMP wants a newline" bug, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 08/26] qmp: Improve QMP dispatch error messages, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 14/26] qapi: Make string input and opts visitor require non-null input, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 17/26] qapi: Drop unused non-strict qobject input visitor, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 24/26] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 12/26] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 16/26] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 21/26] tests: Cover partial input visit of list, Markus Armbruster, 2017/02/28
- [Qemu-devel] [PULL 10/26] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/02/28
- Re: [Qemu-devel] [PULL 00/26] QAPI patches for 2017-02-28,
no-reply <=