[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] using fdt_setprop() to set properties to empty values
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] using fdt_setprop() to set properties to empty values |
Date: |
Wed, 1 Mar 2017 11:16:02 +1100 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Mon, Feb 27, 2017 at 10:11:57AM +0000, Peter Maydell wrote:
> On 27 February 2017 at 01:05, David Gibson <address@hidden> wrote:
> > On Fri, Feb 24, 2017 at 10:35:35AM +0000, Peter Maydell wrote:
> >> On 24 February 2017 at 00:16, David Gibson <address@hidden> wrote:
> >> > Ok, I've pushed libfdt upstream patches to (a) make passing NULL to
> >> > setprop() with zero length explicitly safe and (b) add an
> >> > fdt_setprop_empty() helper macro. Do you want me to make a pullreq to
> >> > update the qemu submodule?
> >>
> >> Yes, please. Are we OK with using a random libfdt commit or do
> >> we update only to proper release tags?
> >
> > I'm find with a random SHA, but that's not really my department - I'm
> > upstream libfdt maintainer, but update policy in the qemu tree seems
> > like a qemu side decision.
> >
> >> There's no real rush with
> >> this so if you have a release due shortly it might be better
> >> to wait for that.
> >
> > dtc/libfdt releases are a rather haphazard affair. Usually they
> > happen when somebody complains that there hasn't been a release with
> > some feature they want. Our tests are both fast to run and have
> > reasonaably good coverage, so random commits are usually good. So a
> > "release" is usually just slapping a new version number onto whatever
> > is in master and making a tag and tarball.
>
> >From my end I think we'd rather use a proper release version
> (if only because it's then easier to refer to and to state
> as a dependency for packaged versions if required). It looks
> like we've done that for our previous updates (starting
> with 1.3.0 and then moving to 1.4.0 and 1.4.2) so I think
> we should continue using released versions.
Ok; I just tagged and released dtc 1.4.3. I'll send a qemu update
when I get a chance to remind myself how to do submodule updates
again.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [Qemu-devel] using fdt_setprop() to set properties to empty values, Peter Maydell, 2017/02/23
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, Eric Blake, 2017/02/23
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, David Gibson, 2017/02/23
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, David Gibson, 2017/02/23
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, Peter Maydell, 2017/02/24
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, David Gibson, 2017/02/26
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, Peter Maydell, 2017/02/27
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values,
David Gibson <=
- Re: [Qemu-devel] using fdt_setprop() to set properties to empty values, David Gibson, 2017/02/28