[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v4 17/28] qom: Make object_property_set_qobject()'s
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v4 17/28] qom: Make object_property_set_qobject()'s input visitor strict |
Date: |
Fri, 3 Mar 2017 13:32:37 +0100 |
Commit 240f64b made all qobject input visitors created outside tests
strict, except for the one in object_property_set_qobject(). That one
was left behind only because Eric couldn't spare the time to figure
out whether making it strict would break anything, with a TODO
comment. Time to resolve it.
Strict makes a difference only for otherwise successful visits of QAPI
structs or unions. Let's examine what the callers of
object_property_set_qobject() visit:
* object_property_set_str(), object_property_set_bool(),
object_property_set_int() visit a QString, QBool, QInt,
respectively. Strictness can't matter.
* qmp_qom_set visits its @value argument. Comes straight from QMP and
can be anything ('any' in the QAPI schema). Strictness matters when
the property's set() method visits a struct or union QAPI type.
No such methods exist, thus switching to strict can't break
anything.
If we acquire such methods in the future, we'll *want* the visitor
to be strict, so that unexpected members get rejected as they should
be.
Switch to strict.
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
---
qom/qom-qobject.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qom/qom-qobject.c b/qom/qom-qobject.c
index 447e4a0..bbdedda 100644
--- a/qom/qom-qobject.c
+++ b/qom/qom-qobject.c
@@ -22,8 +22,8 @@ void object_property_set_qobject(Object *obj, QObject *value,
const char *name, Error **errp)
{
Visitor *v;
- /* TODO: Should we reject, rather than ignore, excess input? */
- v = qobject_input_visitor_new(value, false);
+
+ v = qobject_input_visitor_new(value, true);
object_property_set(obj, v, name, errp);
visit_free(v);
}
--
2.7.4
- [Qemu-devel] [PATCH v4 18/28] test-qobject-input-visitor: Use strict visitor, (continued)
- [Qemu-devel] [PATCH v4 18/28] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 01/28] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 11/28] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 06/28] qapi-introspect: Mangle --prefix argument properly for C, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 04/28] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 12/28] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 15/28] qapi: Drop string input visitor method optional(), Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 27/28] qapi: Fix object input visit beyond end of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 17/28] qom: Make object_property_set_qobject()'s input visitor strict,
Markus Armbruster <=
- [Qemu-devel] [PATCH v4 26/28] tests: Cover input visit beyond end of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 23/28] tests: Cover partial input visit of list, Markus Armbruster, 2017/03/03
- [Qemu-devel] [PATCH v4 25/28] qapi: Make input visitors detect unvisited list tails, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 24/28] test-qobject-input-visitor: Cover missing nested struct member, Markus Armbruster, 2017/03/03
[Qemu-devel] [PATCH v4 28/28] qapi: Improve qobject visitor documentation, Markus Armbruster, 2017/03/03