[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backen

From: Andrea Arcangeli
Subject: Re: [Qemu-devel] [PATCH v3] os: don't corrupt pre-existing memory-backend data with prealloc
Date: Fri, 3 Mar 2017 17:10:39 +0100
User-agent: Mutt/1.8.0 (2017-02-23)

On Fri, Mar 03, 2017 at 11:32:55AM +0000, Daniel P. Berrange wrote:
> When using a memory-backend object with prealloc turned on, QEMU
> will memset() the first byte in every memory page to zero. While
> this might have been acceptable for memory backends associated
> with RAM, this corrupts application data for NVDIMMs.
> Instead of setting every page to zero, read the current byte
> value and then just write that same value back, so we are not
> corrupting the original data. Directly write the value instead
> of memset()ing it, since there's no benefit to memset for a
> single byte write.
> Signed-off-by: Daniel P. Berrange <address@hidden>
> ---
> Changed in v3:

Reviewed-by: Andrea Arcangeli <address@hidden>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]