[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 11/13] sm501: Add some more missing registers
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 11/13] sm501: Add some more missing registers |
Date: |
Fri, 3 Mar 2017 18:33:14 +0000 |
On 10 December 2016 at 02:05, BALATON Zoltan <address@hidden> wrote:
> This is to allow clients to initialise these without failing as long
> as no 2D engine function is called that would use the written value.
> Saved values are not used yet (may get used when more of 2D engine is
> added sometimes) and clients normally only write to most of these
> registers, nothing is known to ever read them but they are documented
> as read/write so also implement read for these.
>
> Signed-off-by: BALATON Zoltan <address@hidden>
> ---
>
> v2: Fixed mask of video_control register for a read only bit
> Changed IRQ status register to write ignored as IRQ is not implemented
> v3: Squashed read implementation into this patch
>
> hw/display/sm501.c | 107
> ++++++++++++++++++++++++++++++++++++++++++++++++++++-
> 1 file changed, 106 insertions(+), 1 deletion(-)
>
> @@ -1454,6 +1558,7 @@ static void sm501_reset(SM501State *s)
> s->misc_timing = 0;
> s->power_mode_control = 0;
> s->dc_panel_control = 0x00010000; /* FIFO level 3 */
> + s->dc_video_control = 0;
> s->dc_crt_control = 0x00010000;
> s->twoD_control = 0;
> }
You want to reset all these new fields, not just one of them.
If you do that then you can add
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM
- [Qemu-devel] [PATCH v3 09/13] sm501: Misc clean ups, (continued)
- [Qemu-devel] [PATCH v3 09/13] sm501: Misc clean ups, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 07/13] sm501: Fix device endianness, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 10/13] sm501: Add support for panel layer, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 02/13] sm501: Use defined constants instead of literal values where available, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 06/13] sm501: Add emulation of chip connected via PCI, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 12/13] sm501: Add vmstate descriptor, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 11/13] sm501: Add some more missing registers, BALATON Zoltan, 2017/03/02
- Re: [Qemu-devel] [PATCH v3 11/13] sm501: Add some more missing registers,
Peter Maydell <=
- [Qemu-devel] [PATCH v3 04/13] sm501: QOMify, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 05/13] sm501: Get rid of base address in draw_hwc_line, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 03/13] sm501: Add missing arbitration control register, BALATON Zoltan, 2017/03/02
- [Qemu-devel] [PATCH v3 08/13] sm501: Fix hardware cursor, BALATON Zoltan, 2017/03/02