[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.10 0/3] block: Add errp to b{lk, drv}_turn
From: |
Max Reitz |
Subject: |
Re: [Qemu-devel] [PATCH for-2.10 0/3] block: Add errp to b{lk, drv}_turncate() |
Date: |
Mon, 6 Mar 2017 22:14:16 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 |
On 06.03.2017 20:58, address@hidden wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Message-id: address@hidden
> Subject: [Qemu-devel] [PATCH for-2.10 0/3] block: Add errp to b{lk,
> drv}_turncate()
> Type: series
>
> === TEST SCRIPT BEGIN ===
> #!/bin/bash
>
> BASE=base
> n=1
> total=$(git log --oneline $BASE.. | wc -l)
> failed=0
>
> # Useful git options
> git config --local diff.renamelimit 0
> git config --local diff.renames True
>
> commits="$(git log --format=%H --reverse $BASE..)"
> for c in $commits; do
> echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
> if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -;
> then
> failed=1
> echo
> fi
> n=$((n+1))
> done
>
> exit $failed
> === TEST SCRIPT END ===
>
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> From https://github.com/patchew-project/qemu
> - [tag update] patchew/address@hidden -> patchew/address@hidden
> * [new tag] patchew/address@hidden -> patchew/address@hidden
> Auto packing the repository for optimum performance. You may also
> run "git gc" manually. See "git help gc" for more information.
> Switched to a new branch 'test'
> 4ef1757 block: Add some bdrv_truncate() error messages
> 3e348c6 block: Add errp to BD.bdrv_truncate()
> 1ba2c64 block: Add errp to b{lk, drv}_truncate()
>
> === OUTPUT BEGIN ===
> Checking PATCH 1/3: block: Add errp to b{lk, drv}_truncate()...
> Checking PATCH 2/3: block: Add errp to BD.bdrv_truncate()...
> Checking PATCH 3/3: block: Add some bdrv_truncate() error messages...
> ERROR: suspect code indent for conditional statements (7, 11)
> #35: FILE: block/file-posix.c:1358:
> if (offset > raw_getlength(bs)) {
> + error_setg(errp, "Cannot grow device files");
>
> total: 1 errors, 0 warnings, 73 lines checked
Surrounding conditional block is not correctly aligned; pre-existing,
didn't notice. Will fix in v2.
Max
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
> === OUTPUT END ===
>
> Test command exited with code: 1
>
>
> ---
> Email generated automatically by Patchew [http://patchew.org/].
> Please send your feedback to address@hidden
>
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH for-2.10 1/3] block: Add errp to b{lk, drv}_truncate(), (continued)
- [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Max Reitz, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Eric Blake, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Max Reitz, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Eric Blake, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Max Reitz, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Eric Blake, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 3/3] block: Add some bdrv_truncate() error messages, Kevin Wolf, 2017/03/07
Re: [Qemu-devel] [PATCH for-2.10 0/3] block: Add errp to b{lk, drv}_turncate(), no-reply, 2017/03/06
- Re: [Qemu-devel] [PATCH for-2.10 0/3] block: Add errp to b{lk, drv}_turncate(),
Max Reitz <=