[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL v2 03/27] qmp-test: New, covering basic QMP proto
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PULL v2 03/27] qmp-test: New, covering basic QMP protocol |
Date: |
Tue, 07 Mar 2017 09:25:37 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 03/05/2017 02:35 AM, Markus Armbruster wrote:
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Eric Blake <address@hidden>
>> Message-Id: <address@hidden>
>> ---
>> MAINTAINERS | 1 +
>> tests/Makefile.include | 5 +-
>> tests/libqtest.c | 17 ++++--
>> tests/libqtest.h | 8 +++
>> tests/qmp-test.c | 139
>> +++++++++++++++++++++++++++++++++++++++++++++++++
>> 5 files changed, 164 insertions(+), 6 deletions(-)
>> create mode 100644 tests/qmp-test.c
>
> Just now noticing (so a followup patch is fine, no need to stall the
> pull request), but this should probably tweak .gitignore for the new
> test
Covered by the *-test line there. Whether it's a good idea is a
separate question. I don't really like such globs in .gitignore myself.
In Makefiles even less.
> (or maybe we should revive Marc-André's proposal to generate
> .gitignore at make time).
Maintaining .gitignore for generated files manually is tiresome, so
automation would be nice, if we can pull it off -- writing into the
source tree is a bit tricky to get right.
- [Qemu-devel] [PULL v2 00/27] QAPI patches for 2017-02-28, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 11/27] qapi: Clean up after commit 3d344c2, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 06/27] qapi-introspect: Mangle --prefix argument properly for C, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 12/27] qapi: Make QObject input visitor set *list reliably, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 03/27] qmp-test: New, covering basic QMP protocol, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 02/27] libqtest: Work around a "QMP wants a newline" bug, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 09/27] qmp: Eliminate silly QERR_QMP_* macros, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 01/27] qga: Fix crash on non-dictionary QMP argument, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 23/27] test-qobject-input-visitor: Cover missing nested struct member, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 17/27] test-qobject-input-visitor: Use strict visitor, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 26/27] qapi: Fix object input visit beyond end of list, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 10/27] qapi: Improve a QObject input visitor error message, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 04/27] qmp: Dumb down how we run QMP command registration, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 16/27] qom: Make object_property_set_qobject()'s input visitor strict, Markus Armbruster, 2017/03/05
- [Qemu-devel] [PULL v2 13/27] qapi: Improve qobject input visitor error reporting, Markus Armbruster, 2017/03/05