[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] block: Fix blockdev-snapshot error handli
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] block: Fix blockdev-snapshot error handling |
Date: |
Tue, 7 Mar 2017 13:32:59 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 06.03.2017 um 21:23 hat Eric Blake geschrieben:
> On 03/06/2017 10:21 AM, Kevin Wolf wrote:
> > For blockdev-snapshot, external_snapshot_prepare() accepts an arbitrary
> > node reference at first and only checks later whether it already has a
> > backing file. Between those places, other errors can occur.
> >
> > Therefore checking in external_snapshot_abort() whether state->new_bs
> > has a backing file is not sufficient to tell whether bdrv_append() was
> > already completed or not. Trying to undo the bdrv_append() when it
> > wasn't even executed is wrong.
> >
> > Introduce a new boolean flag in the state to fix this.
> >
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> > blockdev.c | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> Reviewed-by: Eric Blake <address@hidden>
>
> By the way, how are you finding all these spots? Is it existing qemu-io
> tests that are failing? And if so, would mentioning which test exposed
> the problem being fixed be worth adding in the commit messages? If not,
> are there some qemu-io tests to be added?
Most of the fixes here are based on qemu-iotests failures that only
appeared after fixing the error path in change_parent_backing_link(),
which is now later in this series. So there is no commit at which
qemu-iotests cases are actually failing, even though they helped me spot
some problems.
Kevin
pgpdsozNQz1Wr.pgp
Description: PGP signature
- Re: [Qemu-devel] [PATCH 02/10] mirror: Fix permission problem with 'replaces', (continued)
- [Qemu-devel] [PATCH 03/10] mirror: Fix permissions for removing mirror_top_bs, Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 04/10] mirror: Fix error path for dirty bitmap creation, Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 06/10] block: Factor out should_update_child(), Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 05/10] block: Fix blockdev-snapshot error handling, Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 07/10] block: Factor out bdrv_replace_child_noperm(), Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 08/10] block: Ignore multiple children in bdrv_check_update_perm(), Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 09/10] block: Handle permission errors in change_parent_backing_link(), Kevin Wolf, 2017/03/06
- [Qemu-devel] [PATCH 10/10] block: Fix error handling in bdrv_replace_in_backing_chain(), Kevin Wolf, 2017/03/06
- Re: [Qemu-devel] [PATCH 00/10] block: Op blocker fixes, Fam Zheng, 2017/03/07
- Re: [Qemu-devel] [PATCH 00/10] block: Op blocker fixes, Kevin Wolf, 2017/03/07