[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support |
Date: |
Fri, 10 Mar 2017 12:33:44 +0800 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
On Tue, Mar 07, 2017 at 11:32:29AM +0100, Alberto Garcia wrote:
> On Fri 03 Mar 2017 02:51:48 PM CET, Stefan Hajnoczi wrote:
>
> > +static uint64_t raw_max_size(QemuOpts *opts, BlockDriverState *in_bs,
> > + Error **errp)
> > +{
> > + if (in_bs) {
> > + int64_t size = bdrv_nb_sectors(in_bs);
> > + if (size < 0) {
> > + error_setg_errno(errp, -size, "Unable to get image size");
> > + return 0;
> > + }
> > + return (uint64_t)size * BDRV_SECTOR_SIZE;
> > + }
>
> Why not use bdrv_getlength() directly? It gives you the size in bytes.
Good idea. Will fix.
signature.asc
Description: PGP signature
- [Qemu-devel] [RFC 0/4] qemu-img: add max-size subcommand, Stefan Hajnoczi, 2017/03/03
- [Qemu-devel] [RFC 1/4] block: add bdrv_max_size() API, Stefan Hajnoczi, 2017/03/03
- [Qemu-devel] [RFC 2/4] raw-format: add bdrv_max_size() support, Stefan Hajnoczi, 2017/03/03
- [Qemu-devel] [RFC 3/4] qemu-img: add max-size subcommand, Stefan Hajnoczi, 2017/03/03
- [Qemu-devel] [RFC 4/4] iotests: add test 178 for qemu-img max-size, Stefan Hajnoczi, 2017/03/03
- Re: [Qemu-devel] [RFC 0/4] qemu-img: add max-size subcommand, John Snow, 2017/03/03
- Re: [Qemu-devel] [RFC 0/4] qemu-img: add max-size subcommand, Nir Soffer, 2017/03/03