[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] e1000e: correctly tear down MSI-X memory region

From: Jason Wang
Subject: Re: [Qemu-devel] [PATCH] e1000e: correctly tear down MSI-X memory regions
Date: Fri, 10 Mar 2017 18:59:18 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 2017年03月09日 20:05, Laurent Vivier wrote:
On 09/03/2017 12:58, Paolo Bonzini wrote:
MSI-X has been disabled by the time the e1000e device is unrealized, hence
msix_uninit is never called.  This causes the object to be leaked, which
shows up as a RAMBlock with empty name when attempting migration.

Reported-by: Dr. David Alan Gilbert <address@hidden>
Cc: Jason Wang <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
  hw/net/e1000e.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c
index b0f429b..6e23493 100644
--- a/hw/net/e1000e.c
+++ b/hw/net/e1000e.c
@@ -306,7 +306,7 @@ e1000e_init_msix(E1000EState *s)
  static void
  e1000e_cleanup_msix(E1000EState *s)
-    if (msix_enabled(PCI_DEVICE(s))) {
+    if (msix_present(PCI_DEVICE(s))) {
          e1000e_unuse_msix_vectors(s, E1000E_MSIX_VEC_NUM);
          msix_uninit(PCI_DEVICE(s), &s->msix, &s->msix);

Tested-by: Laurent Vivier <address@hidden>

Applied, thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]