Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

[Markus Armbruster]

Germano Veit Michel <address@hidden> writes:

> On Fri, Mar 3, 2017 at 10:06 PM, Markus Armbruster <address@hidden> wrote:
>>>> diff --git a/qapi-schema.json b/qapi-schema.json
>>>> index baa0d26..0d9bffd 100644
>>>> --- a/qapi-schema.json
>>>> +++ b/qapi-schema.json
>>>> @@ -6080,3 +6080,21 @@
>>>>  #
>>>>  ##
>>>>  { 'command': 'query-hotpluggable-cpus', 'returns': ['HotpluggableCPU'] }
>>>> +
>>>> +##
>>>> +# @announce-self:
>>>> +#
>>>> +# Trigger generation of broadcast RARP frames to update network switches.
>>>> +# This can be useful when network bonds fail-over the active slave.
>>>> +#
>>>> +# Arguments: None.
>>
>> Please drop this line.
>>
>>>> +#
>>>> +# Example:
>>>> +#
>>>> +# -> { "execute": "announce-self" }
>>>> +# <- { "return": {} }
>>>> +#
>>>> +# Since: 2.9
>>>> +##
>>>> +{ 'command': 'announce-self' }
>>>> +
>>
>
> Hi Markus,
>
> Are you talking about the whole example section or just the empty line
> at the end?

The "Arguments: None" line.

[...]