[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] hw/net: implement MIB counters in mcf_fec dri

From: Jason Wang
Subject: Re: [Qemu-devel] [PATCHv2] hw/net: implement MIB counters in mcf_fec driver
Date: Mon, 13 Mar 2017 14:17:38 +0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0

On 2017年03月13日 12:56, Greg Ungerer wrote:
The FEC ethernet hardware module used on ColdFire SoC parts contains a
block of RAM used to maintain hardware counters. This block is accessible
via the usual FEC register address space. There is currently no support
for this in the QEMU mcf_fec driver.

Add support for storing a MIB RAM block, and provide register level
access to it. Also implement a basic set of stats collection functions
to populate MIB data fields.

This support tested running a Linux target and using the net-tools
"ethtool -S" option. As of linux-4.9 the kernels FEC driver makes
accesses to the MIB counters during its initialization (which it never
did before), and so this version of Linux will now fail with the QEMU

     qemu: hardware error: mcf_fec_read: Bad address 0x200

This MIB counter support fixes this problem.

Signed-off-by: Greg Ungerer<address@hidden>
Reviewed-by: Laurent Vivier<address@hidden>
  hw/net/mcf_fec.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
  1 file changed, 115 insertions(+)

v2: clean up checkpatch issues

Applied, thanks.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]