[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH v2 15/30] trace: Fix parameter types in hw/dma

From: Eric Blake
Subject: [Qemu-devel] [PATCH v2 15/30] trace: Fix parameter types in hw/dma
Date: Mon, 13 Mar 2017 14:55:32 -0500

An upcoming patch will let the compiler warn us when we are silently
losing precision in traces; update the trace definitions to pass
through the full value at the callsite.

Signed-off-by: Eric Blake <address@hidden>
 hw/dma/trace-events | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/hw/dma/trace-events b/hw/dma/trace-events
index 22878df..88dae95 100644
--- a/hw/dma/trace-events
+++ b/hw/dma/trace-events
@@ -14,16 +14,16 @@ sparc32_dma_set_irq_lower(void) "Lower IRQ"
 espdma_memory_read(uint32_t addr) "DMA read addr 0x%08x"
 espdma_memory_write(uint32_t addr) "DMA write addr 0x%08x"
 sparc32_dma_mem_readl(uint64_t addr, uint32_t ret) "read dmareg %"PRIx64": 
-sparc32_dma_mem_writel(uint64_t addr, uint32_t old, uint32_t val) "write 
dmareg %"PRIx64": 0x%08x -> 0x%08x"
+sparc32_dma_mem_writel(uint64_t addr, uint32_t old, uint64_t val) "write 
dmareg %"PRIx64": 0x%08x -> 0x%08" PRIx64
 sparc32_dma_enable_raise(void) "Raise DMA enable"
 sparc32_dma_enable_lower(void) "Lower DMA enable"

 # hw/dma/sun4m_iommu.c
 sun4m_iommu_mem_readl(uint64_t addr, uint32_t ret) "read reg[%"PRIx64"] = %x"
-sun4m_iommu_mem_writel(uint64_t addr, uint32_t val) "write reg[%"PRIx64"] = %x"
+sun4m_iommu_mem_writel(uint64_t addr, uint64_t val) "write reg[%"PRIx64"] = %" 
 sun4m_iommu_mem_writel_ctrl(uint64_t iostart) "iostart = %"PRIx64
-sun4m_iommu_mem_writel_tlbflush(uint32_t val) "tlb flush %x"
-sun4m_iommu_mem_writel_pgflush(uint32_t val) "page flush %x"
+sun4m_iommu_mem_writel_tlbflush(uint64_t val) "tlb flush %" PRIx64
+sun4m_iommu_mem_writel_pgflush(uint64_t val) "page flush %" PRIx64
 sun4m_iommu_page_get_flags(uint64_t pa, uint64_t iopte, uint32_t ret) "get 
flags addr %"PRIx64" => pte %"PRIx64", *pte = %x"
 sun4m_iommu_translate_pa(uint64_t addr, uint64_t pa, uint32_t iopte) "xlate 
dva %"PRIx64" => pa %"PRIx64" iopte = %x"
 sun4m_iommu_bad_addr(uint64_t addr) "bad addr %"PRIx64

reply via email to

[Prev in Thread] Current Thread [Next in Thread]