[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.9 03/47] qapi: Back out doc comments added just to please qapi.py
Date: Mon, 13 Mar 2017 16:13:55 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> This reverts commit 3313b61's changes to tests/qapi-schema/, except
> for tests/qapi-schema/doc-*.
> Signed-off-by: Markus Armbruster <address@hidden>
> ---

Tested by doing:

$ git checkout 3313b61
$ git cherry-pick 07c7b92 # the current id on your qapi-doc branch
$ git diff HEAD^^ --stat tests/qapi-schema | grep -v /doc-
 72 files changed, 164 insertions(+)

Reviewed-by: Eric Blake <address@hidden>

>  200 files changed, 92 insertions(+), 1074 deletions(-)

It's a shame we did that much busywork adding test documentation in the
first place.  But it was incomplete (as I found out when trying to
convert some existing tests of failures into new tests of success, by
adding features like anonymous bases to flat unions), and indeed does
not add much value.

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]