Re: [Qemu-devel] [PATCH] hw/net/virtio-net.c: Follow CODING_STYLE

[Eric Blake]

On 03/14/2017 02:52 AM, Zhang Chen wrote:
> Signed-off-by: Zhang Chen <address@hidden>
> ---
>  hw/net/virtio-net.c | 53 
> +++++++++++++++++++++++++++++++++--------------------
>  1 file changed, 33 insertions(+), 20 deletions(-)
> 
> diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
> index c321680..ede618e 100644
> --- a/hw/net/virtio-net.c
> +++ b/hw/net/virtio-net.c
> @@ -273,7 +273,7 @@ static void virtio_net_set_status(struct VirtIODevice 
> *vdev, uint8_t status)
>          if (queue_started) {
>              if (q->tx_timer) {
>                  timer_mod(q->tx_timer,
> -                               qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 
> n->tx_timeout);
> +                         qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + 
> n->tx_timeout);

Indentation still looks off.  You want the two q's to be in the same column.

Otherwise looks okay. Wholesale reformatting of a file with no other
changes tends to make 'git blame' attribution a bit noisier than
necessary, so it's a maintainer's judgment call whether to take it.  But
with the indentation fixed, you can add:
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature