[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property

From: Janne Huttunen
Subject: [Qemu-devel] [RFC][PATCH 0/6] "bootonceindex" property
Date: Tue, 14 Mar 2017 14:50:07 +0200

This series implements a "bootonceindex" property for setting the boot
source priorities for the next boot only. In principle it is supposed
to do the same thing as the '-boot once=' argument but in a compatible
way with the 'bootindex' mechanism.

The basic idea is to have a second list that is sorted by the values
of the "bootonceindex" properties. When the boot order is requested,
the new list is returned if it is not empty and the list is cleared.
The normal bootindex list is only used when there are no devices on
the "once" list.

So far I have only added the support for a couple of devices and
lightly tested it on x86_64 system emulation.

Some questions:

  - Is there already some (reasonable) way to accomplish the same
    effect in QEMU?

  - Does this approach make sense? Any better ideas?

  - Any suggestions for better function / property names?

  - Should the series be split or squashed differently? I tried to
    make it easy to review, but...

  - Are the object life times (no dangling pointers left behind)
    and (lack of) locking correct? As far as I can see, they should
    be, but someone with more experience with this codebase may see
    something I don't...

  - If this approach is going to be merged, any volunteers for
    converting the rest of the devices? Or can the conversion be
    left to be done one by one at some later date? I can try to
    convert more of them, but testing them all is likely not going
    to be possible.

  - Any other suggestions/ideas/comments?

Janne Huttunen (6):
  Re-factor bootdevice list handling, pt1.
  Re-factor bootdevice list handling, pt2.
  Add support for "bootonceindex" property.
  Clear the boot once list after it has been used.
  Support "bootonceindex" property for virtio-net interfaces.
  Support "bootonceindex" property for SCSI disks.

 bootdevice.c             | 112 ++++++++++++++++++++++++++++++++++++-----------
 hw/net/virtio-net.c      |   3 ++
 hw/nvram/fw_cfg.c        |   2 +
 hw/ppc/spapr.c           |   2 +
 hw/s390x/ipl.c           |   2 +
 hw/scsi/scsi-bus.c       |   3 ++
 hw/virtio/virtio-pci.c   |   2 +
 include/hw/block/block.h |   1 +
 include/net/net.h        |   1 +
 include/sysemu/sysemu.h  |   4 ++
 10 files changed, 106 insertions(+), 26 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]