[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 21/47] qapi2texi: Present the table of m

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.9 21/47] qapi2texi: Present the table of members more clearly
Date: Tue, 14 Mar 2017 13:08:43 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> The table of members follows the main descriptive text immediately.
> Makes it hard to see what it is about.  Start a new paragraph, and
> lead with a line "Members:" for object and alternate types, "Values:"
> for enumeration types, and "Arguments:" for commands and events.
> Example change (qemu-qmp-ref.txt):
>   -- Command: set_link
>       Sets the link status of a virtual network adapter.
> +
> +     Arguments:
>       'name'
>            the device name of the virtual network adapter
>       'up'
>            true to set the link status to be up
>       Returns: Nothing on success If 'name' is not a valid network
>       device, DeviceNotFound
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi2texi.py | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]