[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH for-2.9 32/47] qapi: Move detection of doc / exp

From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH for-2.9 32/47] qapi: Move detection of doc / expression name mismatch
Date: Tue, 14 Mar 2017 15:43:30 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 03/13/2017 01:18 AM, Markus Armbruster wrote:
> Move the check whether the doc matches the expression name from
> check_definition_doc() to check_exprs().  This changes the error
> location from the comment to the expression.  Makes sense as the
> message talks about the expresion: "Definition of '%s' follows


> documentation for '%s'".  It's also a step towards getting rid of
> check_docs().
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  scripts/qapi.py                      | 28 ++++++++++++++++++----------
>  tests/qapi-schema/doc-bad-symbol.err |  2 +-
>  2 files changed, 19 insertions(+), 11 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]