[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.9 07/47] qapi: Clean up build of generated
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH for-2.9 07/47] qapi: Clean up build of generated documentation |
Date: |
Wed, 15 Mar 2017 06:53:15 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/15/2017 02:08 AM, Markus Armbruster wrote:
>>> +++ b/.gitignore
>>> @@ -103,11 +103,11 @@
>>> /docs/qemu-ga-ref.txt
>>
>> [1]
>>
>>> /docs/qemu-qmp-ref.html
>>> /docs/qemu-qmp-ref.txt
>>> -docs/qemu-ga-ref.info*
>>> -docs/qemu-qmp-ref.info*
>>> -/qemu-ga-qapi.texi
>>> -/qemu-qapi.texi
>>> -/version.texi
>>> +/docs/qemu-ga-ref.info*
>>
>> worth sorting this line up by [1]?
>
> Fine with me, except I think we should either not mess with the order,
> or go all the way, i.e. ...
>
>>> +/docs/qemu-qmp-ref.info*
>>> +/docs/qemu-ga-qapi.texi
>
> ... move this one, too. Feeding to sort leads to this incremental
> patch:
>
> @@ -99,14 +99,14 @@
> /pc-bios/optionrom/kvmvapic.img
> /pc-bios/s390-ccw/s390-ccw.elf
> /pc-bios/s390-ccw/s390-ccw.img
> +/docs/qemu-ga-qapi.texi
> /docs/qemu-ga-ref.html
> +/docs/qemu-ga-ref.info*
> /docs/qemu-ga-ref.txt
> +/docs/qemu-qmp-qapi.texi
> /docs/qemu-qmp-ref.html
> -/docs/qemu-qmp-ref.txt
> -/docs/qemu-ga-ref.info*
> /docs/qemu-qmp-ref.info*
> -/docs/qemu-ga-qapi.texi
> -/docs/qemu-qmp-qapi.texi
> +/docs/qemu-qmp-ref.txt
> /docs/version.texi
> *.tps
> .stgit-*
Works for me (I always find fully-sorted lists easier to modify, because
I don't have to guess whether inserting new stuff is grouped sanely).
>>> MAKEINFO=makeinfo
>>> -MAKEINFOFLAGS=--no-split --number-sections
>>> +MAKEINFOFLAGS=--no-split --number-sections -I docs
>>
>> Will this cause grief on any older makinfo versions (such as RHEL 6)? I
>> didn't test myself on those setups. I guess if a buildbot doesn't flag
>> you, it's okay.
>
> RHEL-6 has texinfo 4.13, and its manual page documents -I. No mention
> in NEWS, which goes back to 2.2.
Phew, we're safe then.
>
>> The sorting issue is worth fixing, but trivial, so you can add:
>>
>> Reviewed-by: Eric Blake <address@hidden>
>
> Thanks!
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH for-2.9 13/47] qapi: Fix QAPISchemaEnumType.is_implicit() for 'QType', (continued)
- [Qemu-devel] [PATCH for-2.9 22/47] qapi2texi: Explain enum value undocumentedness more clearly, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 12/47] qapi/rocker: Fix up doc comment notes on optional members, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 18/47] qapi: Use raw strings for regular expressions consistently, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 23/47] qapi2texi: Don't hide undocumented members and arguments, Markus Armbruster, 2017/03/13
- [Qemu-devel] [PATCH for-2.9 28/47] qapi2texi: Generate descriptions for simple union tags, Markus Armbruster, 2017/03/13