[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH v2 30/30] trace: Force compiler warnings on
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [RFC PATCH v2 30/30] trace: Force compiler warnings on trace parameter type mismatches |
Date: |
Wed, 15 Mar 2017 14:59:55 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 |
On 03/13/2017 02:55 PM, Eric Blake wrote:
> ---
>
> RFC for two reasons:
> 1. the Makefile issue documented above means that incremental
> builds won't benefit from this patch without manual intervention
> (fresh builds, including docker, manage to test it, though)
Dan's posted the fix for this one.
> 2. there are still failures under 'make address@hidden'
> due to more type mismatches that still need to be squashed. I'm
> still working on fixing those, but wanted to at least post this
> series for initial review, especially so the maintainer can weigh
> in on how much (or little) belongs in 2.9
mingw is a nightmare. Things like ntohl() having non-standard behavior
on 32-bit mingw can only be worked around by hairy redefinitions in
osdep.h or by casts at the callsites. See the conversation in 6/30, but
I'm hoping gcc will give us a new knob to tone down the level of
-Wformat warnings for two types that have different rank but the same
width; if gcc gives us that, then we'd add a configure test, and
conditionally generate the type-mismatch checking code ONLY when gcc is
smart enough to not care about rank mismatch. Until then, this RFC
30/30 proved useful for flushing out the earlier cleanups (many of which
you can/should still accept), but should NOT be incorporated as-is, not
even when 2.10 opens.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-devel] [PATCH v2 21/30] trace: Fix parameter types in hw/net, (continued)
- [Qemu-devel] [PATCH v2 19/30] trace: Fix parameter types in hw/isa, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 22/30] trace: Fix parameter types in hw/nvram, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 24/30] trace: Fix parameter types in hw/sd, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 26/30] trace: Fix parameter types in hw/timer, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 23/30] trace: Fix parameter types in hw/ppc, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 28/30] trace: Fix parameter types in hw/vfio, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 27/30] trace: Fix parameter types in hw/usb, Eric Blake, 2017/03/13
- [Qemu-devel] [RFC PATCH v2 30/30] trace: Force compiler warnings on trace parameter type mismatches, Eric Blake, 2017/03/13
- Re: [Qemu-devel] [RFC PATCH v2 30/30] trace: Force compiler warnings on trace parameter type mismatches,
Eric Blake <=
- [Qemu-devel] [PATCH v2 29/30] trace: Fix parameter types in hw/virtio, Eric Blake, 2017/03/13
- [Qemu-devel] [PATCH v2 25/30] trace: Fix parameter types in hw/scsi, Eric Blake, 2017/03/13
- Re: [Qemu-devel] [PATCH for-2.9 v2 00/30] trace type mismatch cleanups, no-reply, 2017/03/13